-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres tests #760
Postgres tests #760
Conversation
Jenkins BuildsClick to see older builds (51)
|
@jakubgs The tests stages seems to be stuck. There hasn't been any status reported for more than an hr. I have added postgres test that requirees starting postgres db container. |
Fixed. |
@jakubgs Getting this nix error:
|
Previously the store was being tested against sqlite3. After this PR, it will only be tested against postgres. Since persistence is imported in all the examples, i had to add pgx as dependency in all the go.mod. We can move the test for store to persistence/utils, and use fixtures for testing against both postgres and sqlite. This will also remove the need to add pgx as dependency to all the test. And will be a lot better, we don't need to Register pgx in sql.Driver in persistence store:
|
@jakubgs Getting this nix error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool.
if you decide to Squash & Merge the PR, do remember to change the name to match the format (something like feat: postgresql tests
), or just use rebase & merge since the individual commit messages are fine :)
Description
Changes
Tests